Skip to content

MQE-911: [GitHub] Added the ability to use entity properties in metadata #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 28, 2018
Merged

MQE-911: [GitHub] Added the ability to use entity properties in metadata #253

merged 4 commits into from
Nov 28, 2018
+26 −6

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Oct 19, 2018

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@jilu1 jilu1 changed the title [GitHub] PR 76 with static test failure fix [GitHub PR] Added the ability to use entity properties in metadata Oct 19, 2018
@jilu1 jilu1 changed the title [GitHub PR] Added the ability to use entity properties in metadata MQE-911: [GitHub] Added the ability to use entity properties in metadata Oct 19, 2018
@coveralls
Copy link

coveralls commented Oct 19, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 57.054% when pulling e79fe13 on MQE-911 into a304e8e on develop.

@magento-engcom-team magento-engcom-team deleted the MQE-911 branch November 9, 2018 11:28
@VladimirZaets VladimirZaets restored the MQE-911 branch November 9, 2018 14:00
@VladimirZaets VladimirZaets reopened this Nov 9, 2018
KevinBKozan
KevinBKozan approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, changes work.
Take care though, this PR seems to contain contents from #250. Make sure that MQE-910-develop is merged before merging this PR.

@jilu1 jilu1 merged commit 349c9bf into develop Nov 28, 2018
@jilu1 jilu1 deleted the MQE-911 branch August 30, 2019 19:27
magento-devops-reposync-svc pushed a commit that referenced this pull request Dec 6, 2022
@jilu1
Merge pull request #253 from magento-gl/master
0140482 
Merging release back to master  3.12.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jilu1 @coveralls @KevinBKozan @VladimirZaets @magento-engcom-team @Cristian101